NepuShiro/libsm64
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Remove atan2f() function definition.

Browse Source 
`atan2f()` is not used anywhere and collides with `math.h`'s definition of the function, better to remove it entirely. It was causing problems in WebAssembly builds, taking precedence when linking with other codebases that tried to use `atan2f()` from `math.h`.
This commit is contained in:
Renato Rotenberg
2025-01-29 23:49:26 -03:00
parent d5d9914478
commit ce196c823d
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/decomp/engine/math_util.c
+4 -3
View File
@@ -2185,9 +2185,10 @@ s16 atan2s(f32 y, f32 x) {
/**
* Compute the atan2 in radians by calling atan2s and converting the result.
*/
f32 atan2f(f32 y, f32 x) {
return (f32) atan2s(y, x) * M_PI / 0x8000;
}
// libsm64: `atan2f()` is not used anywhere and collides with `math.h`'s definition of the function, better to remove it entirely.
// f32 atan2f(f32 y, f32 x) {
// return (f32) atan2s(y, x) * M_PI / 0x8000;
// }
#define CURVE_BEGIN_1 1
#define CURVE_BEGIN_2 2
src/decomp/engine/math_util.h
+2 -1
View File
@@ -68,7 +68,8 @@ void vec3f_set_dist_and_angle(Vec3f from, Vec3f to, f32 dist, s16 pitch, s16
s32 approach_s32(s32 current, s32 target, s32 inc, s32 dec);
f32 approach_f32(f32 current, f32 target, f32 inc, f32 dec);
s16 atan2s(f32 y, f32 x);
f32 atan2f(f32 a, f32 b);
// libsm64: `atan2f()` is not used anywhere and collides with `math.h`'s definition of the function, better to remove it entirely.
// f32 atan2f(f32 a, f32 b);
void spline_get_weights(Vec4f result, f32 t, UNUSED s32 c);
void anim_spline_init(Vec4s *keyFrames);
s32 anim_spline_poll(Vec3f result);